From eedd14f3cdb01a871c86b15d33fb27dc4244f83d Mon Sep 17 00:00:00 2001 From: psiservices-justin-sullard <70025273+psiservices-justin-sullard@users.noreply.github.com> Date: Wed, 12 Jan 2022 15:47:50 -0600 Subject: [PATCH] Ensure posix compliant joins for urls in middleware (#11640) --- packages/react-dev-utils/noopServiceWorkerMiddleware.js | 2 +- packages/react-dev-utils/redirectServedPathMiddleware.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-dev-utils/noopServiceWorkerMiddleware.js b/packages/react-dev-utils/noopServiceWorkerMiddleware.js index 4e660b57643..0ca939ac562 100644 --- a/packages/react-dev-utils/noopServiceWorkerMiddleware.js +++ b/packages/react-dev-utils/noopServiceWorkerMiddleware.js @@ -11,7 +11,7 @@ const path = require('path'); module.exports = function createNoopServiceWorkerMiddleware(servedPath) { return function noopServiceWorkerMiddleware(req, res, next) { - if (req.url === path.join(servedPath, 'service-worker.js')) { + if (req.url === path.posix.join(servedPath, 'service-worker.js')) { res.setHeader('Content-Type', 'text/javascript'); res.send( `// This service worker file is effectively a 'no-op' that will reset any diff --git a/packages/react-dev-utils/redirectServedPathMiddleware.js b/packages/react-dev-utils/redirectServedPathMiddleware.js index a71578f0a9f..2fda106b04d 100644 --- a/packages/react-dev-utils/redirectServedPathMiddleware.js +++ b/packages/react-dev-utils/redirectServedPathMiddleware.js @@ -19,7 +19,7 @@ module.exports = function createRedirectServedPathMiddleware(servedPath) { ) { next(); } else { - const newPath = path.join(servedPath, req.path !== '/' ? req.path : ''); + const newPath = path.posix.join(servedPath, req.path !== '/' ? req.path : ''); res.redirect(newPath); } };