Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESLint v9.0 #60

Closed
antfu opened this issue Mar 23, 2024 · 4 comments · Fixed by #62
Closed

Support ESLint v9.0 #60

antfu opened this issue Mar 23, 2024 · 4 comments · Fixed by #62

Comments

@antfu
Copy link

antfu commented Mar 23, 2024

The context interface has changed, and removed in v9.0. For example: https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/#context.getscope()

This plugin on ESLint v9.0.0-rc.0 will throw errors like:
image

I tried to check the codebase, but it seems the overall dependencies of this repo are still a bit left behind. Like @typescript-eslint/utils is still v5 while now it's v7 - some the we don't even have the compact types for the new APIs - I wonder what's the strategies of this repo, should we keep support eslint v7 and v8, or we could do a major that only support latest v8.40+ + v9?

@SukkaW
Copy link

SukkaW commented Mar 23, 2024

I tried to check the codebase, but it seems the overall dependencies of this repo are still a bit left behind. Like @typescript-eslint/utils is still v5 while now it's v7

I've already attempted that yesterday. I tried to upgrade ts-eslint/utils from version 5 to version 6 but was unsuccessful. The migration needs to change tons of stuff.

@JounQin
Copy link
Member

JounQin commented Mar 23, 2024

I'm personally fine with dropping legacy eslint versions, but https://github.com/ota-meshi/eslint-compat-utils can also be considered at the same time.

And also I want to upgrade tseslint related packages first, as @SukkaW described, it's not that easy, we need to adapt some rules internally.

@JounQin
Copy link
Member

JounQin commented Mar 24, 2024

Please help to test eslint-plugin-import-x@0.4.2, while flat config is not officially supported yet, it is tracking at #29.

@JounQin
Copy link
Member

JounQin commented Mar 24, 2024

@SukkaW See #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants