Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Import: Upfront Schema Validation #555

Open
pozylon opened this issue Apr 3, 2023 · 0 comments
Open

Bulk Import: Upfront Schema Validation #555

pozylon opened this issue Apr 3, 2023 · 0 comments
Labels
feature request Suggest an idea for this project

Comments

@pozylon
Copy link
Member

pozylon commented Apr 3, 2023

Currently, when somebody sends a JSON-schema validatable invalid event the event only fails inside the BULK_IMPORT work job. In those cases the sending system assumes that the creation worked because adding the job with API resulted in a non-error response.

In those cases, we should check the structure of the whole payload to allow unchained to reject bulk_import up-front and send the response back to the uploading system.

Examples:

  • Invalid JSON
  • An operation without a required field like the translation part of an option for a filter
  • A product with a non-numeric sequence
  • An entity or operation that is not supported by the bulk-importer
@pozylon pozylon added the feature request Suggest an idea for this project label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Suggest an idea for this project
Projects
None yet
Development

No branches or pull requests

1 participant