Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Was called negation is missing in assertion signature in documentation #154

Open
Munter opened this issue Apr 9, 2021 · 2 comments
Open

Comments

@Munter
Copy link
Member

Munter commented Apr 9, 2021

It is possible to assets expect(mySpy, 'was not called'). But the documentation doesn't show this assertion in the left hand menu, nor does it appear in the DSL for was called, which I would expect to say was [not] called

image

The assertions are here: https://github.com/unexpectedjs/unexpected-sinon/blob/master/lib/unexpected-sinon.js#L404-L411

@papandreou
Copy link
Member

PR welcome ;)

@papandreou
Copy link
Member

I guess it's just an artifact of the assertions being defined separately. If you turn them into one that checks expect.flags.not I think it'll come out right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants