Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[] in changelog isn't parsed correctly #46

Open
cuongluu8 opened this issue Aug 24, 2022 · 1 comment
Open

[] in changelog isn't parsed correctly #46

cuongluu8 opened this issue Aug 24, 2022 · 1 comment

Comments

@cuongluu8
Copy link

My changelog is generated by Lerna and looks something like this


# [12.98.0](https://some-git-link) (2022-08-23)


### Features

* **jira-1234:** add some new stuff [incomplete] ([24b358b](https:git-some-link))

When parsed, I use the versions[0].parsed["_"], however the value is jira-1234: add some new stuff incomplete] ([24b358b).

It looks like the [] is confusing the parsing logic and outputs in the wrong place.

@ungoldman
Copy link
Owner

I can see how that could confuse the parser.

In markdown a block like [incomplete] can be reference for a link definition somewhere else in the doc, like:

basdfjadf argj [incomplete] a argihjawrg...

...

[incomplete]: https://en.wikipedia.org/wiki/G%C3%B6del%27s_incompleteness_theorems

Worth figuring out a way to cover this exception. Not sure how soon I'll get to it, if you (or any other brave soul) is willing to wade into some old parser code and get a passing test for this case (or even a failing one), I'd be most grateful.

@ungoldman ungoldman self-assigned this Dec 13, 2022
@ungoldman ungoldman removed their assignment Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants