Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentype SVG support (patches attached) #2657

Open
1 task done
HinTak opened this issue Jan 5, 2024 · 5 comments
Open
1 task done

Opentype SVG support (patches attached) #2657

HinTak opened this issue Jan 5, 2024 · 5 comments

Comments

@HinTak
Copy link

HinTak commented Jan 5, 2024

Description

switching on opentype SVG color font support in chromium

Who's implementing?

  • I'm willing to implement this feature myself

The problem

Upstream issue:

https://bugs.chromium.org/p/chromium/issues/detail?id=306078

although it was marked as "WONT FIX" in 2021, Google engineers actually did most of the work in 2022, but left it disabled. Attached are two patches which switches opentype SVG support on. Tested against patched QT 6.7.0 Beta 1 (which includes a modified/slimmed down chromium m118).

Possible solutions

The patches and the CI to build the fedora RPMS are on https://github.com/HinTak/Qt6WE-OT-SVG/ and tested with PyQt6 in https://github.com/HinTak/minimal-web-browser
s/

. In a nutshell, try visiting either https://yoksel.github.io/color-fonts-demo/ or https://pixelambacht.nl/chromacheck/ before and after applying the patches.

They are discussed in https://github.com/HinTak/chromium-mod-CI .

Alternatives

No response

Additional context

webkit-based browsers and firefox support opentype-svg for some years, and for almost a decade now.

I am aware that the patches need to be adjusted/modified beyond m121/m122 (they are more or less the same in between m112 to m120).

Filed at QT too:
https://bugreports.qt.io/browse/QTBUG-120543

@HinTak
Copy link
Author

HinTak commented Jan 5, 2024

the m120 patches are at https://github.com/HinTak/chromium-mod-CI .

@PF4Public
Copy link
Contributor

What are the benefits of this addition for ungoogled-chromium? Especially w.r.t. project goals?

@HinTak
Copy link
Author

HinTak commented Jan 5, 2024

webkit-based browsers and firefox support opentype-svg for some years, and for almost a decade now.

Chromium derivatives are about a decade behind...

@PF4Public
Copy link
Contributor

Sorry, but I don't see how this could answer my questions.

@HinTak
Copy link
Author

HinTak commented Jan 10, 2024

Added m121/m122 version of patches. Will go on and test them at some point, and if necessary, correct any problems arised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants