Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is it acceptable to add windows specific patch to ungoogled chromium ? #2848

Open
cpuuntery opened this issue May 9, 2024 · 3 comments
Open
Labels

Comments

@cpuuntery
Copy link

cpuuntery commented May 9, 2024

Description

disable emoji from chrome context menu

Who's implementing?

The problem

emoji option in context menu is annoying

Possible solutions

The code responsible for emoji option in context menu is in this link

https://source.chromium.org/chromium/chromium/src/+/main:ui/base/emoji/emoji_panel_helper_win.cc

Alternatives

No response

Additional context

No response

@PF4Public
Copy link
Contributor

It is not very clear what you propose, please add more details.

@PF4Public PF4Public added the need info Need feedback to proceed label May 9, 2024
@networkException
Copy link
Member

emoji option in context menu is annoying

Thats not an argument that would qualify for adding a removal patch. Not here (please take a look at the project goals) and not in the Windows platform repository.

@cpuuntery
Copy link
Author

@networkException
@PF4Public

To me, the patch that I am requesting is no different from these two patches

#1978

#1591

but i guess from your response, Linux take priority over windows when it comes to patching the source code

i know one or two things about c++ and I would more when happy to submit a pull request.

But compiling chromium on i any platform is HELL.
Last I heard, the source code is over 100GB, and you need Threadripper to compile the code under 3 hours

If you still do not agree with me, feel free to close this issue because I don't care any more

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants