Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brush up project #4

Open
mre opened this issue Oct 5, 2018 · 1 comment
Open

Brush up project #4

mre opened this issue Oct 5, 2018 · 1 comment
Labels
enhancement hacktoberfest help-wanted

Comments

@mre
Copy link
Member

mre commented Oct 5, 2018

It's been a while since I looked at this code. Most likely, it would need some love from an eager PHP developer to be up to the latest coding standards.

If anyone wants to tackle this, just add a comment here or create a pull request right away. I can provide mentorship.
@mre
Copy link
Member Author

mre commented Oct 5, 2018

@Douglasdc3 had a few more suggestions in #7:

PSR-2 naming conventions for methods and variables
avoid public accessor api on Dropbox object instead use create wrapper methods for the ones you need on Dropbox class
Upgrade to minimum PHP 5.6 and use short array syntax
Change the namespace and add PSR-4 autoloading suggestion could be Mre\Unicorn

@Leprechaunz Leprechaunz mentioned this issue Oct 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mre