Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerize unicorn! #5

Open
1 of 3 tasks
mre opened this issue Oct 5, 2018 · 3 comments
Open
1 of 3 tasks

Dockerize unicorn! #5

mre opened this issue Oct 5, 2018 · 3 comments
Labels
enhancement hacktoberfest help-wanted

Comments

@mre
Copy link
Member

mre commented Oct 5, 2018 •
edited

Being able to run the project in a container would be nice.

Todo:

  • Create a Dockfile.
  • Add instructions on how to build the image.
  • Push the image to Dockerhub.
@Leprechaunz Leprechaunz mentioned this issue Oct 10, 2018
Merged
@florianorben florianorben mentioned this issue Oct 20, 2018
Closed
@mre
Copy link
Member Author

mre commented Oct 22, 2018

Actually there are already two PRs open for this. #11 and #12. We should probably merge the best parts of those into one.

@Leprechaunz
Copy link
Collaborator

@mre Is there an issues that blocks us from merging one of PRs?

@mre
Copy link
Member Author

mre commented Oct 26, 2018

Ah, not really. I'm just undecided which one to merge.
Both look quite nice, so probably the best of both. I haven't tested #12 yet, that's why I didn't go forward yet. Could you?
If you're happy with what you see (thumbnails working, routes as expected, documentation, etc), could you merge his changes into your PR and then we go from there? I think that's a good compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mre @Leprechaunz