Add macro for "mkmp" mount option

[razvand]

Feature request summary

Use a macro name such as LIBVFSCORE_INITRD_OPT_MKMP for "mkmp" mount option in lib/vfscore/automount.c, instead of just the string "mkmp".

Describe alternatives

No response

Related architectures

None

Related platforms

None

Additional context

This is to make things more configurable and as a good practice: work with a macro instead of a direct value / string.

[pranjalrai4]

@razvand Hi! I am a Computer Science student at the University of Texas at Austin. I am currently taking virtualization (CS 360v) and I would like to contribute to this project. I saw this issue opened up last year and I would like to work on it, but I was wondering if it was still open.

[razvand]

Hi, @pranjalrai4 , sure, go for it.

[pranjalrai4]

@razvand Are we supposed to use the LIBVFSCORE_INITRD_OPT_MKMP macro specifically for the "mkmp" instances? If so, it doesn't exist. If not, do we use a different macro and how do we know which macro to use? Finally, we only see one instance of string "mkmp" in the entire codebase. Do we only change this one instance or are there other places? Thank you!

[razvand]

@pranjalrai4 , it's only for that instance. You define the LIBVFSCORE_INITRD_OPT_MKMP macro and assign it to the "mkmp" string. Then, instead of using the "mkmp" string int that one instance, you use LIBVFSCORE_INITRD_OPT_MKMP.

[ggracechoi]

@razvand We're ready to open a PR, but we're just now reading the contributing guidelines and missed a couple of things. We didn't sign off in our commit message and our commit doesn't follow the "[selector]/[component name]: [Your short message]." Should we just include these in our PR? Also, how do we "run the checkpatch.pl on your commit series before opening this PR?"

[razvand]

@ggracechoi , amend your commit to follow the contributing guidelines. See this tutorial on amending commits.

For running checkpatch locally, follow these instructions.