Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Package subpath './browser' is not defined by "exports" in .../common/node_modules/consola/package.json #242

Open
forgetso opened this issue Sep 21, 2023 · 0 comments

Comments

@forgetso
Copy link
Contributor

Environment

npm list consola
marketing-website@1.0.0
├─┬ @prosopo/cli@0.2.0 -> ./../captcha/packages/cli
│ ├─┬ @prosopo/common@0.2.0 -> ./../captcha/packages/common
│ │ └── consola@3.2.3 deduped
├─┬ @prosopo/common@0.2.0 -> ./../captcha/packages/common
│ └── consola@3.2.3
node --version
v18.14.2

Reproduction

  • Create a commonjs package
  • Import the commonJS version of consola.
  • Try to run the commonjs package in the browser
Error: Package subpath './browser' is not defined by "exports" in /common/node_modules/consola/package.json
 new NodeError (node:internal/errors:399:5)
 exportsNotFound (node:internal/modules/esm/resolve:361:10)
 packageExportsResolve (node:internal/modules/esm/resolve:641:13)
 resolveExports (node:internal/modules/cjs/loader:565:36)
 Module._findPath (node:internal/modules/cjs/loader:634:31)
 Module._resolveFilename (node:internal/modules/cjs/loader:1061:27)
 Module._load (node:internal/modules/cjs/loader:920:27)
 Module.require (node:internal/modules/cjs/loader:1141:19)
 require (node:internal/modules/cjs/helpers:110:18)
 Module.<anonymous> (/common/dist/cjs/logger.cjs:5:17)

Describe the bug

Browser cjs path seems to be missing from consola package.json

    "./browser": {
      "types": "./dist/browser.d.ts",
      "import": "./dist/browser.mjs"
    },

But the cjs file is present in consola dist

/node_modules/consola/dist/browser.cjs

This could potentially be fixed simply by adding the path to package.json

    "./browser": {
      "types": "./dist/browser.d.ts",
      "import": "./dist/browser.mjs",
      "require": "./dist/browser.cjs"
    },

Additional context

No response

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant