feat(peer): add close and terminate #36
Conversation
|
I'm unsure if this is the desired direction, and I haven't tested the different implementations, only Node. Feel free to push any changes you wish |
| @@ -108,4 +108,15 @@ class CloudflarePeer extends Peer<{ | |||
| this.ctx.cloudflare.server.send(toBufferLike(message)); | |||
| return 0; | |||
| } | |||
|
|
|||
| close(code?: number, reason?: string) { | |||
| this.ctx.cloudflare.client.close(code, reason); | |||
There was a problem hiding this comment.
I'm not familiar with Cloudflare websockets and having two of them so this could be wrong
| * @param code The close code to send | ||
| * @param reason The close reason to send | ||
| */ | ||
| abstract close(code?: number, reason?: string): void; |
There was a problem hiding this comment.
What do you think to support it as { code?: number, reason?: string, terminate?: boolean } to keep simility? (also many providers might not respect terminate and behave it same as close)
There was a problem hiding this comment.
It's up to you. Given that termination seems to send a specific code, having a direct helper seems to be more appropriate. Most providers seem to have it. When searching online for the feature I found both close() and terminate(), so I would say it's more intuitive to have two distinct methods than one with an extra argument at the very end
There was a problem hiding this comment.
okay, thanks for context. let me research little more when could to decide.
🔗 Linked issue
Close #23
❓ Type of change
📚 Description
📝 Checklist