Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge object strings of many types #44

Merged
merged 3 commits into from Aug 16, 2022
Merged

fix: merge object strings of many types #44

merged 3 commits into from Aug 16, 2022

Conversation

danielroe
Copy link
Member

resolves #41

@danielroe danielroe added the bug Something isn't working label Aug 16, 2022
@danielroe danielroe requested a review from pi0 August 16, 2022 12:33
@danielroe danielroe self-assigned this Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #44 (57a6f50) into main (c21b132) will decrease coverage by 38.46%.
The diff coverage is 42.85%.

❗ Current head 57a6f50 differs from pull request most recent head ac83cf1. Consider uploading reports for the commit ac83cf1 to get more accurate results

@@             Coverage Diff              @@
##              main      #44       +/-   ##
============================================
- Coverage   100.00%   61.53%   -38.47%     
============================================
  Files            1        1               
  Lines           33       65       +32     
  Branches        10       25       +15     
============================================
+ Hits            33       40        +7     
- Partials         0       25       +25     
Impacted Files Coverage Δ
src/defu.ts 61.53% <42.85%> (-38.47%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

test/defu.test.ts Outdated Show resolved Hide resolved
@pi0 pi0 merged commit c7226f9 into main Aug 16, 2022
@pi0 pi0 deleted the fix/partials branch August 16, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

two subset defaults.
2 participants