fix(sendRedirect): only encode required chars in meta tag

unjs · Sep 3, 2022 · a9b992e · a9b992e
1 parent dcf208a
commit a9b992e
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/src/utils/response.ts b/src/utils/response.ts
@@ -24,15 +24,10 @@ export function defaultContentType (event: CompatibilityEvent, type?: string) {
 }
 
 export function sendRedirect (event: CompatibilityEvent, location: string, code = 302) {
-  const encodedLoc = encodeURI(decodeURI(location))
   event.res.statusCode = code
-  event.res.setHeader('Location', encodedLoc)
-  // Minimal html document that redirects on client side
-  const html = `<!DOCTYPE html>
-<html>
-  <head><meta http-equiv="refresh" content="0; url=${encodedLoc}"></head>
-  <body>Redirecting to <a href=${JSON.stringify(encodedLoc)}>${encodedLoc}</a></body>
-</html>`
+  event.res.setHeader('Location', location)
+  const encodedLoc = location.replace(/"/g, '%22')
+  const html = `<!DOCTYPE html><html><head><meta http-equiv="refresh" content="0; url=${encodedLoc}"></head></html>`
   return send(event, html, MIMES.html)
 }