Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import type from correct location #219

Merged
merged 1 commit into from
Nov 2, 2022
Merged

fix: import type from correct location #219

merged 1 commit into from
Nov 2, 2022

Conversation

nmathew98
Copy link
Contributor

@nmathew98 nmathew98 commented Oct 31, 2022 •
edited by danielroe

resolves #216

@nmathew98 nmathew98 changed the title fix: issues with generate TypeScript declaration file fix: issues with generated TypeScript declaration file Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #219 (f9cc83a) into main (087de86) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   76.34%   76.34%           
=======================================
  Files          20       20           
  Lines        1171     1171           
  Branches      222      222           
=======================================
  Hits          894      894           
  Misses        277      277
Impacted Files Coverage Δ
src/utils/proxy.ts 82.60% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danielroe danielroe changed the title fix: issues with generated TypeScript declaration file fix: import type from correct location Oct 31, 2022
pi0
pi0 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pi0 pi0 merged commit 8b89f39 into unjs:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated d.ts causes Type Error
3 participants
@nmathew98 @pi0 @danielroe