Skip to content

fix: type nested/namespaced hooks #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 1, 2021
Merged

fix: type nested/namespaced hooks #32

merged 4 commits into from
Sep 1, 2021
+80 −5

Conversation

danielroe
Copy link
Member

resolves #30

@danielroe
fix: type nested/namespaced hooks
d8a8817
@danielroe
fix: support types with signatures

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
74cfd53
@danielroe danielroe requested a review from pi0 September 1, 2021 11:31
@danielroe danielroe self-assigned this Sep 1, 2021
pi0
pi0 approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ❤️‍🔥

@pi0 pi0 merged commit a0d9146 into main Sep 1, 2021
@danielroe danielroe deleted the fix/type-nested-hooks branch September 1, 2021 18:05
@pi0
Copy link
Member

pi0 commented Sep 1, 2021

Released in 5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0

Assignees

@danielroe danielroe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fully typed nested/namespaced hooks (for addHooks)
2 participants
@danielroe @pi0