feat: import assertions for genImport and genDynamicImport
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
commented
Nov 5, 2022
| @@ -29,6 +29,7 @@ | |||
| "devDependencies": { | |||
| "@nuxtjs/eslint-config-typescript": "latest", | |||
| "c8": "latest", | |||
| "@vitest/coverage-c8": "latest", | |||
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## main #34 +/- ##
=========================================
+ Coverage 0 95.55% +95.55%
=========================================
Files 0 7 +7
Lines 0 225 +225
Branches 0 72 +72
=========================================
+ Hits 0 215 +215
- Misses 0 10 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pi0
reviewed
Nov 7, 2022
pi0
reviewed
Nov 7, 2022
pi0
changed the title
genImport and genDynamicImport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation
In
@nuxtjs/i18n, we need to import i18n resources such as JSON.nuxt-modules/i18n#1518 (comment)
implementation
This PR is implemented with
{ assert?: { type: string } }ofCodegenOptions.Ideally, the arguments of functions such as
genImportshould be implemented with a few more changes as defined in the tc39 spec.https://tc39.es/proposal-import-assertions/
However, that would be a breaking change since it would change the interface, and it would affect the nuxt3 release schedule. so we are implementing it this way.