Skip to content

Commit d115045

Browse files
committedJan 29, 2024
chore: remove ws from shared args for now
1 parent 207e882 commit d115045

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed
 

‎src/cli.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ export const main = defineCommand({
3535
description: "Watch for changes",
3636
alias: "w",
3737
},
38+
ws: {
39+
type: "boolean",
40+
description: "Enable Experimental WebSocket support",
41+
},
3842
...getArgs(),
3943
},
4044
async run({ args }) {
@@ -86,10 +90,6 @@ export function getArgs() {
8690
type: "boolean",
8791
description: "Open the URL in the browser",
8892
},
89-
ws: {
90-
type: "boolean",
91-
description: "Enable Experimental WebSocket support",
92-
},
9393
https: {
9494
type: "boolean",
9595
description: "Enable HTTPS",

5 commit comments

Comments
 (5)

kashalls commented on Feb 22, 2024

@kashalls

@pi0 Was this blocking v1.6.0 or was listhen + crossws not working?

pi0 commented on Feb 22, 2024

@pi0
MemberAuthor

Basically it should be opt-in (implemented) in CLIs that use the future. Only built-ion CLI currently implements it as experimental.

kashalls commented on Feb 22, 2024

@kashalls

Basically it should be opt-in (implemented) in CLIs that use the future. Only built-ion CLI currently implements it as experimental.

I see. I was hoping to be able to test this functionality, but seeing how nitro doesn't fetch those args I can't get it to work. Is there a way to implement this functionality outside of the listhen cli and in nitro for the meantime?

pi0 commented on Feb 22, 2024

@pi0
MemberAuthor

I am on it ;)

kashalls commented on Feb 22, 2024

@kashalls

I am on it ;)

Thank you! I appreciate it. Feel free to mention me or in the Nuxtjs discord for help/debugging/testing.

Please sign in to comment.