Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid double // at end of url #30

Merged
merged 2 commits into from Jun 15, 2022
Merged

fix: avoid double // at end of url #30

merged 2 commits into from Jun 15, 2022

Conversation

danielroe
Copy link
Member

No description provided.

@danielroe danielroe requested a review from pi0 June 15, 2022 12:55
@danielroe danielroe self-assigned this Jun 15, 2022
@danielroe danielroe added the bug Something isn't working label Jun 15, 2022
@pi0
Copy link
Member

pi0 commented Jun 15, 2022

Isn't withoutLeadingSlash on line before prenthing this? If not (and I think it is better) we can remove that other workaround and rely on joinURL

@pi0 pi0 merged commit 2322064 into main Jun 15, 2022
@pi0 pi0 deleted the fix/base-url branch June 15, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @pi0