Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass hostname to getPort as well #34

Merged
merged 1 commit into from Aug 3, 2022
Merged

fix: pass hostname to getPort as well #34

merged 1 commit into from Aug 3, 2022

Conversation

danielroe
Copy link
Member

what port is available depends on the hostname we're checking, but we were always checking localhost, even when we were listening on another port

See nuxt/nuxt#14476.

@danielroe danielroe added the bug Something isn't working label Aug 3, 2022
@danielroe danielroe requested a review from pi0 August 3, 2022 13:58
@danielroe danielroe self-assigned this Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #34 (48ee18f) into main (f4ab4f7) will increase coverage by 0.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      nuxt/framework#34      +/-   ##
==========================================
+ Coverage   38.30%   38.62%   +0.31%     
==========================================
  Files           3        3              
  Lines         577      580       +3     
  Branches       28       28              
==========================================
+ Hits          221      224       +3     
  Misses        328      328              
  Partials       28       28              
Impacted Files Coverage Δ
src/index.ts 81.57% <100.00%> (+0.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 0ced0a4 into main Aug 3, 2022
@pi0 pi0 deleted the fix/port branch August 3, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants