Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass port options object to getPort #47

Merged
merged 1 commit into from
Nov 28, 2022
Merged

fix: pass port options object to getPort #47

merged 1 commit into from
Nov 28, 2022

Conversation

mrkswrnr
Copy link
Contributor

@mrkswrnr mrkswrnr commented Nov 18, 2022 •
edited

Fixes #46

@pi0 pi0 changed the title fix: advanced options for port are not passed to get-port-please (#46) fix: pass port options object to getPort (#46) Nov 28, 2022
@pi0 pi0 changed the title fix: pass port options object to getPort (#46) fix: pass port options object to getPort Nov 28, 2022
pi0
pi0 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@pi0 pi0 merged commit 8cc07e0 into unjs:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

advanced options for port are not passed to get-port-please
2 participants
@mrkswrnr @pi0