Skip to content

Commit 7c1bda4

Browse files
authoredJun 16, 2022
fix: make url optional in resolver created with createResolve (#44)
1 parent 37d5bcc commit 7c1bda4

File tree

4 files changed

+12
-5
lines changed

4 files changed

+12
-5
lines changed
 

‎src/resolve.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ export function resolvePath (id: string, opts?: ResolveOptions) {
118118
}
119119

120120
export function createResolve (defaults?: ResolveOptions) {
121-
return (id, url) => {
121+
return (id: string, url?: ResolveOptions['url']) => {
122122
return resolve(id, { url, ...defaults })
123123
}
124124
}

‎test/fixture/eval-err.mjs

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
async function test() {
1+
// @ts-nocheck
2+
// eslint-disable-next-line require-await
3+
async function test () {
24
throw new Error('Something went wrong in eval-err module!')
35
}
46

‎test/fixture/resolve.mjs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { resolvePath, createResolve, resolveImports } from 'mlly'
22

3-
import.meta.resolve = createResolve({ url: import.meta.url })
4-
console.log(await import.meta.resolve('./cjs.mjs'))
3+
const resolve = createResolve({ url: import.meta.url })
4+
console.log(await resolve('./cjs.mjs'))
55

66
console.log(await resolvePath('./cjs.mjs', { url: import.meta.url }))
77
console.log(await resolvePath('./foo', { url: import.meta.url }))
88

9-
console.log(await resolveImports(`import foo from './eval.mjs'`, { url: import.meta.url }))
9+
console.log(await resolveImports('import foo from \'./eval.mjs\'', { url: import.meta.url }))

‎tsconfig.json

+5
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@
33
"target": "ESNext",
44
"module": "ESNext",
55
"moduleResolution": "Node",
6+
"resolveJsonModule": true,
67
"esModuleInterop": true,
8+
"checkJs": true,
9+
"paths": {
10+
"mlly": ["./"]
11+
},
712
"types": [
813
"node"
914
]

0 commit comments

Comments
 (0)
Please sign in to comment.