Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure we don't resolve modules in parent folders #200

Closed
danielroe opened this issue Oct 20, 2023 · 2 comments
Closed

ensure we don't resolve modules in parent folders #200

danielroe opened this issue Oct 20, 2023 · 2 comments

Comments

@danielroe
Copy link
Member

Not sure if this is relevant still but opening it here just in case.

nuxt/nuxt#20616 (comment)
@pi0
Copy link
Member

pi0 commented Oct 20, 2023

Thanks for making issue. Yes it is relevant i saw it multiple times but need to make a minimal reproduction (or test fixture) to make sure we don't introduce any side-effect regressions by making this change (however I'm pretty sure with all tests it will break some implicit cases that mlly was working for nested node_modules resolution, wrongly-and-correctly!)

@pi0
Copy link
Member

pi0 commented Jan 11, 2024

Let's track in #158

@pi0 pi0 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pi0 @danielroe