Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow /esm/*.js for isValidNodeImport #23

Closed
pi0 opened this issue Nov 16, 2021 · 0 comments
Closed

Disallow /esm/*.js for isValidNodeImport #23

pi0 opened this issue Nov 16, 2021 · 0 comments

Comments

@pi0
Copy link
Member

pi0 commented Nov 16, 2021

Reference: nuxt/framework#1949

Libraries like date-fns (as of 2.25.0) using this contention leading to native ESM incompatibility (https://unpkg.com/browse/date-fns@2.25.0/esm/format/)

Using a regex like /\/esm\/.*\.js$/ we can exclude it but we should probably still take type: module check into account to avoid false-positive detections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant