Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(findExports): filtering for named exports #55

Merged
merged 3 commits into from Jun 29, 2022
Merged

Conversation

antfu
Copy link
Member

@antfu antfu commented Jun 27, 2022

The filtering introduced in #40 incidentally filtered out named exports like:

[
  { type: 'named', names: ['foo', /* ... */] },
  { type: 'named', names: ['bar', /* ... */] },
]

to becomes

[
  { type: 'named', names: ['bar', /* ... */] },
]

Due to both of the exports having undefined of the name property.

@antfu antfu requested a review from danielroe June 27, 2022 15:57
@danielroe
Copy link
Member

Nice catch!

@pi0 pi0 merged commit df908fd into main Jun 29, 2022
@pi0 pi0 deleted the fix/exports-named branch June 29, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants