Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backwards-compatible layer for old static route rules #1145

Closed
danielroe opened this issue Apr 15, 2023 · 2 comments · Fixed by #1155
Closed

add backwards-compatible layer for old static route rules #1145

danielroe opened this issue Apr 15, 2023 · 2 comments · Fixed by #1155
Assignees
Labels
enhancement New feature or request

Comments

@danielroe
Copy link
Member

danielroe commented Apr 15, 2023

Currently with implementation of #946 we drop the static cache rule.

This is a breaking change for users who deploy to Vercel or Netlify and use the static or swr rules, as mentioned in #1124.

Because Nuxt has a caret version constraint, I would request that we add a layer for backwards compatibility in the next release, and would also suggest moving back to ~ constraint in Nuxt to allow features like this to be released in minors.

@pi0
Copy link
Member

pi0 commented Apr 17, 2023

This is a good idea to keep converting swr to isr for a while while updating docs and communicating. But also as mentioned in the initial PR, this is not particularly a breaking change but fix breaking change as sometimes we have in Nuxt too :) SWR behavior will keep working on both platforms and also closer to what is expected.

Fix for static to isr makes sense btw.

@danielroe
Copy link
Member Author

I wouldn't consider it a breaking fix. We even documented that swr and static were the way to implement ISR on Netlify + Vercel. But as long as we have backwards compatibility and don't remove until next major, I think it's totally fine.

@pi0 pi0 closed this as completed in #1155 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants