Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extname): avoid regex lookbehinds for safari support #42

Merged
merged 1 commit into from Aug 18, 2022
Merged

Conversation

danielroe
Copy link
Member

resolves #41

@danielroe danielroe requested a review from pi0 August 18, 2022 08:43
@danielroe danielroe self-assigned this Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #42 (4144607) into main (aa7772d) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   63.86%   63.86%           
=======================================
  Files           4        4           
  Lines         274      274           
  Branches       99       99           
=======================================
  Hits          175      175           
  Partials       99       99           
Impacted Files Coverage Δ
src/path.ts 63.98% <50.00%> (ø)
src/utils.ts 66.66% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix: remove lookbehinds (for safari support) fix(extname): avoid regex lookbehinds for safari support Aug 18, 2022
@pi0 pi0 merged commit c0cec97 into main Aug 18, 2022
@pi0 pi0 deleted the fix/safari branch August 18, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extname is not supported in safari
2 participants