Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): rename licence to license #17

Merged
merged 1 commit into from Jul 29, 2022
Merged

fix(types): rename licence to license #17

merged 1 commit into from Jul 29, 2022

Conversation

Cansiny0320
Copy link
Contributor

No description provided.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielroe
Copy link
Member

Might be worth keeping old spelling as deprecated.

@danielroe danielroe changed the title chore: typo fix(types): rename licence -> license Jul 29, 2022
@Cansiny0320
Copy link
Contributor Author

Might be worth keeping old spelling as deprecated.

i think licence is a wrong use,should not be marked as deprecated

Copy link
Member

danielroe commented Jul 29, 2022

The fact that we have [key: string]: any type signature means tthat users will simply have their .licence typed as any, rather than being prompted to change the spelling.

[key: string]: any

@pi0
Copy link
Member

pi0 commented Jul 29, 2022

The fact that we have [key: string]: any type signature means that users will have their .licence typed as any, rather than being prompted to change the spelling.

This fix is only for type support. We do not have any runtime logic that reflects to deprecating and renaming this field. This is more of a generic issue that we allow artibrary keys to be same as package.json...

@pi0 pi0 changed the title fix(types): rename licence -> license fix(types): rename licence to license Jul 29, 2022
@pi0 pi0 merged commit ddda0b5 into unjs:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants