Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: findFarthestFile #32

Merged
merged 4 commits into from Sep 6, 2022
Merged

feat: findFarthestFile #32

merged 4 commits into from Sep 6, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 6, 2022

In order to detect files from workspace dir, we probably need to look from up to down for the most far file (lockfile, .git or package.json). This can also have some edge cases but i suppose safer than looking from closest to up if combined with multiple checks.

(related: #14)

@pi0 pi0 requested a review from danielroe September 6, 2022 11:00
@pi0 pi0 merged commit 0d8319e into main Sep 6, 2022
@pi0 pi0 deleted the feat/find-farthest branch September 6, 2022 11:03
@pi0 pi0 mentioned this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant