Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

fix: fixed package.json types when using anything other than "moduleResolution": "commonJs" #7

Merged
merged 2 commits into from
Jul 4, 2023
Merged

fix: fixed package.json types when using anything other than "moduleResolution": "commonJs" #7

merged 2 commits into from
Jul 4, 2023

Conversation

favna
Copy link
Contributor

@favna favna commented May 22, 2023 •
edited

This is required when setting TypeScript's moduleResolution to anything other than CommonJS. For example, when set to bundler or Node16

@favna favna mentioned this pull request May 22, 2023
Merged
danielroe
danielroe reviewed May 23, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@pi0
Copy link
Owner

pi0 commented Jul 4, 2023

Thanks!

@pi0 pi0 merged commit 47fe343 into pi0:main Jul 4, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@favna @pi0 @danielroe