Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias do not be checked in rollup.external. #383

Open
s3xysteak opened this issue Apr 5, 2024 · 0 comments · May be fixed by #384
Open

Alias do not be checked in rollup.external. #383

s3xysteak opened this issue Apr 5, 2024 · 0 comments · May be fixed by #384

Comments

@s3xysteak
Copy link

Environment

Node.js: v20.10.0
pnpm: v8.15.6

Reproduction

https://github.com/s3xysteak/unbuild-alias-error

pnpm i
pnpm build

It will throw a error and stop building.
Change code in src/index.ts:

// export * from '@/two'
export * from './two'

Run pnpm build, it can build correctly.

Describe the bug

Refer to code:

ctx.options.rollup.inlineDependencies ||

Alias was not be respected in external check. So if using a alias instead of relative path, it will not enter this if statement.
The problem can be fixed by inlineDependencies option, but that may not be the user's intention. Refer to #376.

Additional context

No response

Logs

No response

@s3xysteak s3xysteak linked a pull request Apr 5, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant