Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pkg): add types field for exports #89

Merged
merged 1 commit into from Jul 20, 2022
Merged

fix(pkg): add types field for exports #89

merged 1 commit into from Jul 20, 2022

Conversation

meteorlxy
Copy link
Contributor

@meteorlxy meteorlxy commented Jun 23, 2022 •
edited

Currently, build.config.ts does not compat with "moduleResolution": "Node16" in tsconfig.

An alternative solution is to support build.config.mts

Before

image

After

image

pi0
pi0 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks <3

@pi0 pi0 changed the title build: compat with ts node16 module resolution fix(pkg): add types field for exports Jul 20, 2022
@pi0 pi0 merged commit 457f043 into unjs:main Jul 20, 2022
pi0 added a commit that referenced this pull request Jul 20, 2022
@pi0
fix(pkg): use default export condition to avoid breaking change
858d35d 
changes from #89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@meteorlxy @pi0