Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: exit with code (1) on build warnings #98

Merged
merged 19 commits into from Aug 10, 2022

Conversation

danielroe
Copy link
Member

resolves #9

@danielroe danielroe added the enhancement New feature or request label Jul 25, 2022
@danielroe danielroe requested a review from pi0 July 25, 2022 14:56
@danielroe danielroe self-assigned this Jul 25, 2022
@pi0
Copy link
Member

pi0 commented Jul 25, 2022

Instead, can we please introduce fail on warn flag and enable by default?

src/builder/rollup.ts Outdated Show resolved Hide resolved
@danielroe danielroe requested a review from pi0 July 25, 2022 15:48
@pi0
Copy link
Member

pi0 commented Aug 10, 2022

Updated warning to show summary in the end:

image

@pi0 pi0 changed the title feat!: fail builds if implicit externals are detected feat!: exit with code (1) on build warnings Aug 10, 2022
@pi0 pi0 merged commit ffc0d7c into main Aug 10, 2022
@pi0 pi0 deleted the feat/fail-on-implicit-externals branch August 10, 2022 11:51
@pi0
Copy link
Member

pi0 commented Aug 10, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fail on dependency issues
2 participants