Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): fix JSON innerHTML encoding #219

Merged
merged 1 commit into from Sep 9, 2023

Conversation

vetruvet
Copy link
Contributor

@vetruvet vetruvet commented Sep 8, 2023

πŸ”— Linked issue

#218

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Noticed that escapeJSON in tagToString is called but its output is not used.
Moved up a few lines so its result is used when setting content later.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly. (n/a?)

@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
unjs-unhead βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 8, 2023 7:14pm

@harlan-zw
Copy link
Collaborator

Amazing, thank you for catching this!

@harlan-zw harlan-zw merged commit 0ad87cc into unjs:main Sep 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants