Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When we run the webpackback with the report in fancy, the previous instructions in the terminal are lost #56

Open
hrodriguez758 opened this issue Sep 20, 2019 · 0 comments

Comments

@hrodriguez758
Copy link

Version

v3.0.0

Steps to reproduce

Run with the reporter option in fancy

What is expected ?

The output should be

$ yarn build
yarn run v1.17.3
$ yarn build:release
$ lerna run build:release --stream
lerna notice cli v3.16.4
lerna info Executing command in 1 package: "yarn run build:release"
application: $ yarn build:release:application && yarn build:release:renderer
application: $ webpack --color --mode production --config webpack.main.config.js
✔ Webpack
application:   Compiled successfully in 1.47s
application: $ webpack --color --mode production --config webpack.renderer.config.js
✔ Webpack
application:   Compiled successfully in 1.91s
lerna success run Ran npm script 'build:release' in 1 package in 6.1s:
lerna success - application
✨  Done in 6.98s.

What is actually happening?

The current output is

application: ✔ Webpack
application:   Compiled successfully in 1.93s
lerna success run Ran npm script 'build:release' in 1 package in 6.1s:
lerna success - application
✨  Done in 6.93s.

Additional comments?

Basically the method _renderStates in the FancyReporter class is adding unnecessaries jump lines ("\n")

  _renderStates(statesArray) {
    lastRender = Date.now();
    const renderedStates = statesArray.map(c => this._renderState(c)).join('\n\n');
    logUpdate.render("\n" + renderedStates + "\n");
  }

The fix for this issue is just to remove the unnecessaries jump lines like this:

  _renderStates(statesArray) {
    lastRender = Date.now();
    const renderedStates = statesArray.map(c => this._renderState(c)).join('\n');
    logUpdate.render(renderedStates);
  }
This bug report is available on Nuxt community (#c39)
@ghost ghost added the cmty:bug-report label Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant