fix: count variant metrics based on enabled state #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredrikOseberg
commented
Dec 22, 2022
| @@ -211,15 +211,15 @@ export class UnleashClient extends TinyEmitter { | |||
| const enabled = toggle?.enabled || false; | |||
| const variant = toggle ? toggle.variant : defaultVariant; | |||
|
|
|||
| this.metrics.count(toggleName, true); | |||
| this.metrics.count(toggleName, enabled); | |||
There was a problem hiding this comment.
This line is the important change.
gastonfournier
approved these changes
Dec 22, 2022
kwasniew
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
This PR fixes a bug where getVariant would always count as true, disregarding the enabled state of the toggle.
Closes #
Important files
Discussion points