fix: nodejs support by default #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tymek
force-pushed
the
fix/isomorphic-platform
branch
2 times, most recently
from
81e7f46
to
ef19397
Compare
Signed-off-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
Tymek
force-pushed
the
fix/isomorphic-platform
branch
from
ef19397
to
7a645c1
Compare
ivarconr
reviewed
Jan 12, 2023
ivarconr
reviewed
Jan 12, 2023
| @@ -76,7 +76,7 @@ const storeKey = 'repo'; | |||
|
|
|||
| export const resolveFetch = () => { | |||
| try { | |||
| if ('fetch' in window) { | |||
| if (typeof window !== 'undefined' && 'fetch' in window) { | |||
There was a problem hiding this comment.
why not if(window && 'fetch' in window)?
There was a problem hiding this comment.
Checking if window is truthy can still trigger TS error "window is not defined"
ivarconr
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
windowis undefined without additional configurationInMemoryStorageProvider