Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix docs & tarojs example #64

Merged
merged 3 commits into from
May 28, 2024
Merged

chore: fix docs & tarojs example #64

merged 3 commits into from
May 28, 2024

Conversation

ModyQyW
Copy link
Member

@ModyQyW ModyQyW commented May 17, 2024 •
edited

close #61

@netlify Netlify
Copy link

netlify bot commented May 17, 2024 •
edited

✅ Deploy Preview for unocss-applet ready!

Name Link
🔨 Latest commit 3472bf6
🔍 Latest deploy log https://app.netlify.com/sites/unocss-applet/deploys/6647583b94a2620008e12c2d
😎 Deploy Preview https://deploy-preview-64--unocss-applet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ModyQyW
Copy link
Member Author

ModyQyW commented May 17, 2024

@zguolee @Skiyee 请求CR，晚点还有一个PR：uni-helper/unocss-preset-uni#20

Skiyee
Skiyee approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@Skiyee Skiyee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤ LGTM

@Skiyee
Copy link
Member

Skiyee commented May 20, 2024

这个 = 不太好处理，好像被过滤掉了

unocss-applet/packages/preset-applet/src/transformers.ts

Lines 29 to 30 in ff43ab4

const replacements = Array.from(matched).filter(i => charTestReg.test(i))
.filter(i => !i.includes('='))

@Skiyee Skiyee mentioned this pull request May 21, 2024
Merged
@Skiyee
Copy link
Member

Skiyee commented May 21, 2024

😁 嘻嘻，等号过滤问题，我试着修复了一下，@ModyQyW @zguolee 朋友们看看

@zguolee zguolee merged commit 69dc804 into unocss-applet:main May 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skiyee Skiyee Skiyee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"unocss/vite" resolved to an ESM file.
3 participants
@ModyQyW @Skiyee @zguolee