fix(autocomplete): cartesian product mistake (#2929)

unocss · Aug 1, 2023 · 44ec3c8 · 44ec3c8
1 parent d44d745
commit 44ec3c8
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/packages/autocomplete/src/utils.ts b/packages/autocomplete/src/utils.ts
@@ -20,8 +20,6 @@ export function searchAttrKey(content: string, cursor: number) {
 }
 
 export function cartesian<T>(arr: T[][]): T[][] {
-  if (arr.length < 2)
-    return arr
   return arr.reduce(
     (a, b) => {
       const ret: T[][] = []

diff --git a/test/utils.test.ts b/test/utils.test.ts
@@ -2,6 +2,7 @@ import { mergeDeep } from '@unocss/core'
 import { getComponent } from '@unocss/preset-mini/utils'
 import { expect, it } from 'vitest'
 import { addRemToPxComment, getColorString } from '@unocss/vscode/utils'
+import { cartesian } from '@unocss/autocomplete'
 
 it('mergeDeep', () => {
   expect(mergeDeep<any>({
@@ -114,3 +115,26 @@ it('addRemToPxComment', () => {
   expect(addRemToPxComment(text, 0)).eql(text)
   expect(addRemToPxComment(text, -1)).eql(text)
 })
+
+it('cartesian', () => {
+  const a = ['a', 'b', 'c']
+  const b = ['1', '2', '3']
+  // multiple
+  expect(cartesian([a, b])).eql([
+    ['a', '1'],
+    ['a', '2'],
+    ['a', '3'],
+    ['b', '1'],
+    ['b', '2'],
+    ['b', '3'],
+    ['c', '1'],
+    ['c', '2'],
+    ['c', '3'],
+  ])
+  // single
+  expect(cartesian([a])).eql([
+    ['a'],
+    ['b'],
+    ['c'],
+  ])
+})