Skip to content

Commit

Permalink
fix: shadow does not take into account custom color (#3391)
Browse files Browse the repository at this point in the history
  • Loading branch information
Scrum committed Nov 29, 2023
1 parent efe4f5a commit 859cae6
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 3 deletions.
15 changes: 12 additions & 3 deletions packages/preset-mini/src/_utils/utilities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -214,11 +214,20 @@ export function colorableShadows(shadows: string | string[], colorVar: string) {
const components = getStringComponents(shadows[i], ' ', 6)
if (!components || components.length < 3)
return shadows
const color = parseCssColor(components.pop())
if (color == null)

if (parseCssColor(components.at(0)))
return shadows
colored.push(`${components.join(' ')} var(${colorVar}, ${colorToString(color)})`)

let colorVarValue = ''
if (parseCssColor(components.at(-1))) {
const color = parseCssColor(components.pop())
if (color)
colorVarValue = `, ${colorToString(color)}`
}

colored.push(`${components.join(' ')} var(${colorVar}${colorVarValue})`)
}

return colored
}

Expand Down
20 changes: 20 additions & 0 deletions test/layer.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,26 @@ describe('layers', () => {
expect(css).toMatchSnapshot()
})

it('colors', async () => {
const uno = createGenerator({
theme: {
colors: {
blackA7: 'hsla(0, 0%, 0%, 0.169)',
},
},
presets: [
presetMini(),

],
})
const { css } = await uno.generate('shadow-[0_2px_10px] shadow-blackA7', { preflights: false })
expect(css).toMatchInlineSnapshot(`
"/* layer: default */
.shadow-\\[0_2px_10px\\]{--un-shadow:0 2px 10px var(--un-shadow-color);box-shadow:var(--un-ring-offset-shadow), var(--un-ring-shadow), var(--un-shadow);}
.shadow-blackA7{--un-shadow-opacity:0.169;--un-shadow-color:hsla(0, 0%, 0%, var(--un-shadow-opacity));}"
`)
})

it('@import layer', async () => {
const uno = createGenerator({
presets: [
Expand Down

0 comments on commit 859cae6

Please sign in to comment.