fix(variant-group): filter spaces, close #828

unocss · Jul 20, 2022 · f660cfa · f660cfa
1 parent 671e30b
commit f660cfa
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/packages/core/src/utils/variantGroup.ts b/packages/core/src/utils/variantGroup.ts
@@ -17,6 +17,7 @@ export function expandVariantGroup(str: string | MagicString, seperators: ('-' |
           return from
         return body
           .split(/\s/g)
+          .filter(Boolean)
           .map(i => i === '~' ? pre : i.replace(/^(!?)(.*)/, `$1${pre}${sep}$2`))
           .join(' ')
       },

diff --git a/test/__snapshots__/transformer-variant-group.test.ts.snap b/test/__snapshots__/transformer-variant-group.test.ts.snap
@@ -11,7 +11,7 @@ exports[`transformer-variant-group > basic > "dark:lg:(p-1 p-2)" 1`] = `"dark:lg
 exports[`transformer-variant-group > basic > "hover:(
 !m-2 
 p-2
-)" 1`] = `"hover: !hover:m-2 hover: hover:p-2 hover:"`;
+)" 1`] = `"!hover:m-2 hover:p-2"`;
 
 exports[`transformer-variant-group > basic > "hover:(!m-2 p-2)" 1`] = `"!hover:m-2 hover:p-2"`;
 

diff --git a/test/variant-group.test.ts b/test/variant-group.test.ts
@@ -24,4 +24,8 @@ describe('variant-group', () => {
   test('nested', () => {
     expect(expandVariantGroup('a-(b c-(d e f))')).toEqual('a-b a-c-d a-c-e a-c-f')
   })
+
+  test('spaces', () => {
+    expect(expandVariantGroup('a-( ~ b c )')).toEqual('a a-b a-c')
+  })
 })