Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset-typography): inherit mono font from theme #1000

Merged
merged 2 commits into from May 23, 2022
Merged

feat(preset-typography): inherit mono font from theme #1000

merged 2 commits into from May 23, 2022

Conversation

equt
Copy link
Contributor

@equt equt commented May 23, 2022

I find no reason to hardcode it into DEFAULT. An optimization may forward the Theme to the cssExtend to allow more flexibility and maybe less CSS var, should be a breaking change though.

@equt equt requested a review from ydcjeff as a code owner May 23, 2022 07:19
@netlify
Copy link

netlify bot commented May 23, 2022

Deploy Preview for unocss canceled.

Name Link
🔨 Latest commit 468ff53
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/628b46fb38780500085c143c

@ydcjeff ydcjeff changed the title Avoid hardcoding code font family feat(preset-typography): inherit mono font from theme May 23, 2022
@ydcjeff
Copy link
Member

ydcjeff commented May 23, 2022

Can you update the snapshots? Thanks.

@equt
Copy link
Contributor Author

equt commented May 23, 2022

for sure

@equt equt requested a review from antfu as a code owner May 23, 2022 08:34
@ydcjeff ydcjeff merged commit 49a20e5 into unocss:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants