Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(preset-mini,preset-wind): rework more rules with base properties #1033

Merged
merged 8 commits into from May 30, 2022
Merged

fix(preset-mini,preset-wind): rework more rules with base properties #1033

merged 8 commits into from May 30, 2022

Conversation

chu121su12
Copy link
Collaborator

@chu121su12 chu121su12 commented May 30, 2022 •
edited

Closes #700

@netlify
Copy link

netlify bot commented May 30, 2022 •
edited

✅ Deploy Preview for unocss canceled.

Name Link
🔨 Latest commit 49ec6e6
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/6295117ace030a0009e269c7

@chu121su12 chu121su12 changed the title fix(preset-mini,preset-wind): rework more rules with _base_ properties fix(preset-mini,preset-wind): rework more rules with *base* properties May 30, 2022
@chu121su12 chu121su12 changed the title fix(preset-mini,preset-wind): rework more rules with *base* properties fix(preset-mini,preset-wind): rework more rules with base properties May 30, 2022
@chu121su12 chu121su12 marked this pull request as ready for review May 30, 2022 15:32
@chu121su12 chu121su12 requested a review from antfu as a code owner May 30, 2022 15:32
@chu121su12
Copy link
Collaborator Author

/cc @hannoeru It seems the @apply directive doesn't pickup the preflight layer yet. The earlier rework also remove the css-vars from transform & filters utilities.

@chu121su12 chu121su12 changed the title fix(preset-mini,preset-wind): rework more rules with base properties fix(preset-mini,preset-wind)!: rework more rules with base properties May 30, 2022
@antfu antfu changed the title fix(preset-mini,preset-wind)!: rework more rules with base properties fix(preset-mini,preset-wind): rework more rules with base properties May 30, 2022
@antfu antfu enabled auto-merge (squash) May 30, 2022 18:46
@antfu antfu merged commit 6f695f6 into main May 30, 2022
@chu121su12 chu121su12 mentioned this pull request May 31, 2022
Closed
@ydcjeff ydcjeff deleted the fix/more-preflight branch June 30, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS Custom Property Cascade Leak
2 participants
@chu121su12 @antfu