Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preset-mini,preset-wind): use base property directly #1060

Merged
merged 1 commit into from Jun 3, 2022

Conversation

chu121su12
Copy link
Collaborator

@chu121su12 chu121su12 commented Jun 3, 2022

Maybe related: #1053

I'm not sure how to test this, but the indirection of some utilities are causing the css variables not able to influence isolated web components.

DOM with 2 custom web components:
image

CSS in el-1 as in v0.37.2:
image

CSS in tailwind (el-2, updated in this PR):
image

Preview:
image

@netlify
Copy link

netlify bot commented Jun 3, 2022

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 2a792c0
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/629a18d42724cd00084f4a1e
😎 Deploy Preview https://deploy-preview-1060--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@chu121su12 chu121su12 marked this pull request as ready for review June 3, 2022 14:39
@chu121su12 chu121su12 requested a review from antfu as a code owner June 3, 2022 14:39
@antfu antfu merged commit c259661 into main Jun 3, 2022
@antfu antfu deleted the fix/direct-base-props branch June 3, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants