feat(vscode): resolve config by file path #1101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have changed
unocss.root
.Unsolved problems
Files meetingcode.includes(INCLUDE_COMMENT_IDE) || isCssId(id)
will now be resolved to default config. Should it use the "closest" config or the default one?Should the config file search all the way to the root of the drive? Should it be CWD instead?Should there be a command to unload all loaded contexts(aka. reload)? It definitely helps with potential loading issues (eg. when a new config file is added), but I'm not sure if it's necessary.Reduce the number ofcreateContext
calls. Currently it's being called every time a resolve from cache fails, and it does lot's of disk reads which is slow. I think it could be reduced by a better cache algorithm, haven't came up with one yet.