Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset-icons): automatic svg prologue cleanup #1111

Merged
merged 1 commit into from Jun 18, 2022

Conversation

userquin
Copy link
Member

Updated @iconify/utils to 1.0.33 (includes my PR iconify/iconify#150) and added test on preset-icons.test.ts.

The PR on @iconify/utils just remove all the text above <svg.

closes #959

The cli still locking some resource on my Windows laptop:

imagen

@userquin userquin requested a review from antfu as a code owner June 17, 2022 20:48
@netlify
Copy link

netlify bot commented Jun 17, 2022

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 7b0cc11
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/62ace8a8d1b62c0009668611
😎 Deploy Preview https://deploy-preview-1111--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@userquin userquin changed the title feat: automatic svg prologue cleanup feat(preset-icons): automatic svg prologue cleanup Jun 17, 2022
@userquin
Copy link
Member Author

If you want to include some hint about it on the README just ping me.

@antfu antfu merged commit bd3a6c4 into main Jun 18, 2022
@antfu antfu deleted the userquin/update-iconify-loader-scg-cleanup branch June 18, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom icons generate invalid CSS
2 participants