fix(vscode): autocomplete for css

[TrickyPi]

motivation

support prompt of autocomplete and annotation for css file as before.

cc @QiroNT

[netlify]

✅ Deploy Preview for unocss ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	01fa3ec
🔍 Latest deploy log	https://app.netlify.com/sites/unocss/deploys/62b15ad00ea3ac0008173581
😎 Deploy Preview	https://deploy-preview-1118--unocss.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[QiroNT]

Hi, thanks for the contribution.

I think the changed condition is still the same, and css-like files actually have context cache.

unocss/packages/vscode/src/contextLoader.ts

Lines 235 to 238 in 1097c5b

	if (isSubdir(configDir, file)) {
	this.fileContextCache.set(file, context)
	return context
	}

What's the problem with the current implementation? After fixing #1119 I don't see any issue on my side.

[TrickyPi]

The changed Conditional isn't totally same as before.
https://github.com/unocss/unocss/pull/1118/files#diff-3241d63de07ad5b12662fc4d9f3559f3e4c2836772e8b921612675c05b9f6f87L76
the result of executing context.filter(code, id) is false if the id param is a path of css file，so the prompt of autoComplete for css file does not work.

[QiroNT]

I think... AutoComplete will still work since resolveClosestContext will 100% resolve a context for it.

The current logic before change basically is:

• If resolveContext resolved a context and filter passed, then use the context.
• If it's a css-like file, use the context from resolveClosestContext.
• If none of the above matches, the prompt will not be activated.

There for, css-like files will always get a context either from resolveContext or resolveClosestContext, it should never fail.

EDIT: Oh I know, css-like files which have a context but don't pass the filter will not be resolved.
Is that a real issue? If the file is excluded, I think the autocomplete prompt shouldn't be activated.

[TrickyPi]

it will cause another issue.
Existed the following dir structure

├── index.html
├── package.json
├── pnpm-lock.yaml
├── src
│   ├── App.css
│   ├── App.tsx
│   ├── favicon.svg
│   ├── index.css
│   ├── logo.svg
│   ├── main.tsx
│   └── vite-env.d.ts
├── tsconfig.json
├── tsconfig.node.json
└── vite.config.ts

Actually, the context of css-like file is null
Caused by this code

https://github.com/unocss/unocss/blob/1097c5bd682294a48f32a3ddf2ffaa965a269291/packages/vscode/src/contextLoader.ts#L131toL136

[TrickyPi]

Oh I know, css-like files which have a context but don't pass the filter will not be resolved.
Is that a real issue? If the file is excluded, I think the autocomplete prompt shouldn't be activated.

yeah, it's a real issue(see #985). By the way, i don't know why the defaultExclude contains css-like files.
https://github.com/unocss/unocss/blob/main/packages/shared-integration/src/defaults.ts#L3

[QiroNT]

I see, it's ok.

If resolveClosestContext could be called only when needed then it would be better. It's not that expensive tho.

[antfu]

Can you help resolve the conflicts? Thanks

[TrickyPi]

Ok, just a minute.

[TrickyPi]

Done.