Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): use recursive callback to resolve variant #1126

Merged
merged 7 commits into from Jun 24, 2022
Merged

feat(core): use recursive callback to resolve variant #1126

merged 7 commits into from Jun 24, 2022

Conversation

chu121su12
Copy link
Collaborator

@chu121su12 chu121su12 commented Jun 21, 2022 •
edited

  • update applyVariants
  • deprecate most of VariantHandler properties, moving them to handler()
  • add VariantHandler.handle()

The main goal for this is to enable usecase of #1104 without plenty of selector replace hack, while also still supports #987

@netlify
Copy link

netlify bot commented Jun 21, 2022 •
edited

✅ Deploy Preview for unocss canceled.

Name Link
🔨 Latest commit 84dfb34
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/62b17f4482b1c50008c9c14d

@chu121su12 chu121su12 marked this pull request as ready for review June 21, 2022 00:25
@chu121su12 chu121su12 requested a review from antfu as a code owner June 21, 2022 00:25
@chu121su12 chu121su12 mentioned this pull request Jun 21, 2022
Merged
antfu
antfu reviewed Jun 21, 2022
View reviewed changes
packages/core/src/types.ts Outdated Show resolved Hide resolved
antfu
antfu reviewed Jun 21, 2022
View reviewed changes
packages/core/src/types.ts Outdated Show resolved Hide resolved
antfu
antfu reviewed Jun 21, 2022
View reviewed changes
test/variant-handler.test.ts Outdated Show resolved Hide resolved
@antfu antfu merged commit 7c88219 into main Jun 24, 2022
@antfu antfu deleted the feat/recursive-variant branch June 24, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chu121su12 @antfu