Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset-mini)!: add tagged variants' pseudo in order #1157

Merged
merged 1 commit into from Jun 30, 2022

Conversation

chu121su12
Copy link
Collaborator

@chu121su12 chu121su12 commented Jun 25, 2022

Breaking because currently this

<div class="parent-hover:dark:parent-focus:bg-yellow-600">

bunches the parents together and yields:

.dark .parent:hover:focus>.parent-hover\:dark\:parent-focus\:bg-yellow-600{...}

This PR aligns the behavior with the distinct version (ex.: group & parent):

<div class="group-hover:dark:parent-focus:bg-yellow-600">
.group:hover .dark .parent:focus>.group-hover\:dark\:parent-focus\:bg-yellow-600{...}

Edit: update examples

@netlify
Copy link

netlify bot commented Jun 25, 2022

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit d593b34
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/62b70a94779ae8000ae046d9
😎 Deploy Preview https://deploy-preview-1157--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@chu121su12 chu121su12 marked this pull request as ready for review June 25, 2022 07:12
@chu121su12 chu121su12 requested a review from antfu as a code owner June 25, 2022 07:12
@chu121su12 chu121su12 marked this pull request as draft June 25, 2022 07:15
@chu121su12 chu121su12 marked this pull request as ready for review June 25, 2022 07:16
@chu121su12 chu121su12 marked this pull request as draft June 25, 2022 10:54
@chu121su12 chu121su12 marked this pull request as ready for review June 25, 2022 13:34
@antfu antfu merged commit a40b389 into main Jun 30, 2022
@antfu antfu deleted the fix/tagged-pseudo branch June 30, 2022 03:07
MellowCo added a commit to MellowCo/unocss-preset-weapp that referenced this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants