Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset-mini,preset-wind)!: add more global keywords #1171

Merged
merged 1 commit into from Jun 30, 2022
Merged

Conversation

chu121su12
Copy link
Collaborator

@chu121su12 chu121su12 commented Jun 26, 2022

This PR adds on top of #1170, but instead introduces fix that can be considered breaking change.

  • use border style list from in divide-x style
  • update font-synthesis to use static rules with bracket rules for compund values (See https://developer.mozilla.org/en-US/docs/Web/CSS/font-synthesis#syntax)
  • fix: support global value for animate-x. previously animate-<global> would produce animation-play-state: <global>
  • fix: properly support list-<style>-<outside|inside>
  • fix: line-clamp-none was set to line-clamp: unset
  • add h.global to the related utilites

@netlify
Copy link

netlify bot commented Jun 26, 2022

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 69aa941
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/62b8f62a40b97b00087fb1b0
😎 Deploy Preview https://deploy-preview-1171--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@chu121su12 chu121su12 linked an issue Jun 26, 2022 that may be closed by this pull request
@chu121su12 chu121su12 marked this pull request as ready for review June 26, 2022 09:58
@chu121su12 chu121su12 requested a review from antfu as a code owner June 26, 2022 09:58
@chu121su12 chu121su12 changed the title feat(preset-mini,preset-wind)!: add global keywords feat(preset-mini,preset-wind)!: add more global keywords Jun 26, 2022
@antfu
Copy link
Member

antfu commented Jun 29, 2022

What would be the breaking changes?

@chu121su12
Copy link
Collaborator Author

chu121su12 commented Jun 29, 2022

I guess due to slight behavior change especially in these:

  • changes to font-synthesis rule order (converted to static)
  • the animate-<global>
  • line-clamp-none

Otherwise it can be more of fix update

@antfu antfu merged commit 6a7a396 into main Jun 30, 2022
@antfu antfu deleted the feat/global-2 branch June 30, 2022 03:07
MellowCo added a commit to MellowCo/unocss-preset-weapp that referenced this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants